This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 92.96% 93.51% +0.54%
==========================================
Files 69 54 -15
Lines 3413 2590 -823
==========================================
- Hits 3173 2422 -751
+ Misses 240 168 -72 ☔ View full report in Codecov by Sentry. |
d-perl
force-pushed
the
818_update_system_tests
branch
from
February 1, 2024 14:51
cdff213
to
6f6afa3
Compare
DominicOram
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that with the latest S03 these tests are more reliable than before. more effort needed to get them fully passing but moving that into later issues
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…ource/818_update_system_tests DiamondLightSource/hyperion#818 fix fgs plan system tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts but doesn't finish #818
Requires https://gitlab.diamond.ac.uk/controls/support/bl03s-builder/-/merge_requests/5 and DiamondLightSource/dodal#371
While we're at it, this would be good too:
https://gitlab.diamond.ac.uk/controls/python3/s03_utils/-/merge_requests/14
To test:
Dockerfile
if you aren't building it in/dls_sw/work/${EPICS_VERSION}/support/BL03S-BUILDER
)test_fgs_plan.py
pass