Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

#818 fix fgs plan system tests #944

Merged
merged 12 commits into from
Mar 13, 2024
Merged

#818 fix fgs plan system tests #944

merged 12 commits into from
Mar 13, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Oct 25, 2023

Starts but doesn't finish #818
Requires https://gitlab.diamond.ac.uk/controls/support/bl03s-builder/-/merge_requests/5 and DiamondLightSource/dodal#371

While we're at it, this would be good too:
https://gitlab.diamond.ac.uk/controls/python3/s03_utils/-/merge_requests/14

To test:

  1. Build S03 with updated BL03S-BUILDER (note, you will need to change the install location in the BL03S-BUILDER Dockerfile if you aren't building it in /dls_sw/work/${EPICS_VERSION}/support/BL03S-BUILDER)
  2. Confirm system tests in test_fgs_plan.py pass

@d-perl d-perl requested a review from DominicOram November 2, 2023 12:30
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (e3b7353) to head (cdff213).
Report is 206 commits behind head on main.

❗ Current head cdff213 differs from pull request most recent head 61c95b7. Consider uploading reports for the commit 61c95b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   92.96%   93.51%   +0.54%     
==========================================
  Files          69       54      -15     
  Lines        3413     2590     -823     
==========================================
- Hits         3173     2422     -751     
+ Misses        240      168      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-perl d-perl force-pushed the 818_update_system_tests branch from cdff213 to 6f6afa3 Compare February 1, 2024 14:51
Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that with the latest S03 these tests are more reliable than before. more effort needed to get them fully passing but moving that into later issues

@DominicOram DominicOram merged commit 3499fee into main Mar 13, 2024
5 checks passed
@DominicOram DominicOram deleted the 818_update_system_tests branch March 13, 2024 16:25
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants