Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key in layout attempts to delete read-only links #450

Closed
blondejamtart opened this issue Jan 17, 2019 · 2 comments · Fixed by #452
Closed

Delete key in layout attempts to delete read-only links #450

blondejamtart opened this issue Jan 17, 2019 · 2 comments · Fixed by #452
Assignees
Labels
3 3 points

Comments

@blondejamtart
Copy link
Contributor

No description provided.

@blondejamtart
Copy link
Contributor Author

storm-react-diagrams has a delete behaviour for links and blocks, which we set which keys trigger it and also hook in to fire the messages to malcolm to actually remove the link (without this the link will just be removed from the local layout state but will be redrawn once any update to the layout is received). Currently, we check if the layout is writeable and unbind the delete keys from the layout if it is not. Since storm-react-diagrams will (as standard) delete the link before our hook can check whether or not it is writeable the best solution may be simply to force a redraw of the layout if any links on which delete was called were not writeable.

@blondejamtart
Copy link
Contributor Author

On closer investigation, it looks like we are no longer hooking into the delete behaviour of storm-react-diagrams, so we can disable it completely; this will impact how/when links and blocks disappear from the rendered layout upon deletion to a minor extent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 3 points
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant