Feature/plotter widget #448 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 17, 2019 12:09
…der certain circumstances
…+ other fixes - Layout view button now displays a graphic which looks suitably layout-y - TextInput/Update widgets now format their content + display units based on the display_t from the provided meta - Fixed some widget sizes when displayed in attributeDetails - Added fix to prevent layout attempting to delete/change read-only sink port attributes
added 2 commits
January 31, 2019 15:29
- Fixed plot widget for arrays - Added option of number of points to plot - Improved layout optimistic link delete behaviour - Added code to allow for running auto-layout on local state only - Renamed display_t to display to account for corresponding change in pymalcolm
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=========================================
- Coverage 82.57% 79.97% -2.6%
=========================================
Files 81 85 +4
Lines 3334 3511 +177
Branches 615 656 +41
=========================================
+ Hits 2753 2808 +55
- Misses 512 601 +89
- Partials 69 102 +33
Continue to review full report at Codecov.
|
…ing on button This was acheived by dispatching a new click event to the button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
connect to #448
connect to #322
connect to #447
connect to #450
connect to #321
connect to #6
closes #448
closes #322
closes #447
closes #450
closes #321
closes #6