Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use config server if GDA didn't supply params #496

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented Sep 16, 2024

Fixes #494

Constant values for feature flags now only exist in one place, and FeatureFlags now stores which parameters it was instantiated with so it can prioritise GDA-supplied values

This now requires a GDA change too: instead of setting hyperion_params["use_cpu_and_gpu_zocalo"] and hyperion_params["use_panda"], these features need to be specified in a dictionary. Eg, hyperion_params["features"] = {"use_cpu_and_gpu_zocalo":True, "use_panda":True}

Acceptance criteria

If GDA parameters are supplied for gpu, panda and stub_offsets, these are used. If the parameters are missing, the config server is used instead

@olliesilvester olliesilvester marked this pull request as ready for review September 17, 2024 16:20
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (b23d3dd) to head (dd72b9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   78.30%   78.32%   +0.01%     
==========================================
  Files          93       93              
  Lines        6809     6813       +4     
==========================================
+ Hits         5332     5336       +4     
  Misses       1477     1477              
Components Coverage Δ
i24 SSX 57.15% <ø> (ø)
hyperion 96.48% <88.23%> (+<0.01%) ⬆️
other 95.80% <ø> (ø)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aitbw Angel Perez
@olliesilvester olliesilvester force-pushed the 494_turn_on_experimental_features branch from 75f232c to df08194 Compare October 14, 2024 10:32
@olliesilvester olliesilvester requested a review from d-perl October 15, 2024 15:04
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for reworking it! Minor comments about the comments, up to you

olliesilvester and others added 2 commits October 25, 2024 15:50
Co-authored-by: David Perl <[email protected]>
Co-authored-by: David Perl <[email protected]>
@olliesilvester olliesilvester merged commit 05c6429 into main Oct 25, 2024
22 checks passed
@olliesilvester olliesilvester deleted the 494_turn_on_experimental_features branch October 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide how turn on experimental features
2 participants