-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use config server if GDA didn't supply params #496
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 78.30% 78.32% +0.01%
==========================================
Files 93 93
Lines 6809 6813 +4
==========================================
+ Hits 5332 5336 +4
Misses 1477 1477
|
75f232c
to
df08194
Compare
…tal_features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for reworking it! Minor comments about the comments, up to you
Co-authored-by: David Perl <[email protected]>
Co-authored-by: David Perl <[email protected]>
Fixes #494
Constant values for feature flags now only exist in one place, and
FeatureFlags
now stores which parameters it was instantiated with so it can prioritise GDA-supplied valuesThis now requires a GDA change too: instead of setting
hyperion_params["use_cpu_and_gpu_zocalo"]
andhyperion_params["use_panda"]
, these features need to be specified in a dictionary. Eg,hyperion_params["features"] = {"use_cpu_and_gpu_zocalo":True, "use_panda":True}
Acceptance criteria
If GDA parameters are supplied for gpu, panda and stub_offsets, these are used. If the parameters are missing, the config server is used instead