Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put wavelength into ispyb earlier #566

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #495.

Reads the dcm energy before collection and updates ispyb accordingly

To Test

  • Confirm tests pass

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (2957b1e) to head (93e7626).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   78.21%   78.22%   +0.01%     
==========================================
  Files          92       92              
  Lines        6797     6801       +4     
==========================================
+ Hits         5316     5320       +4     
  Misses       1481     1481              
Components Coverage Δ
i24 SSX 57.17% <ø> (ø)
hyperion 96.24% <100.00%> (+<0.01%) ⬆️
other 100.00% <ø> (ø)

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@DominicOram DominicOram merged commit efbe991 into main Oct 17, 2024
21 checks passed
@DominicOram DominicOram deleted the 495_put_wavelength_in_ispyb_earlier branch October 17, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put wavelength in ispyb earlier
3 participants