Replace calls to deprecated inject() with direct factory calls #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 78.22% 78.22% -0.01%
==========================================
Files 92 92
Lines 6801 6800 -1
==========================================
- Hits 5320 5319 -1
Misses 1481 1481
|
rtuck99
force-pushed
the
replace_inject
branch
from
b205d53 to
15fbb15
Compare
rtuck99
requested review from
olliesilvester,
DominicOram,
noemifrisina and
d-perl
DominicOram
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I'm not sure if this is all we need to do. If we don't wait for connection then is there not a danger that if we immediately try and use the device now we will fail? On the other hand waiting for connection inside the default args I think means that we will be doing work on import?
d-perl
approved these changes
Oct 21, 2024
|
@DominicOram I think the idea is that BlueApi has connected to all the devices before |
DominicOram
added a commit
that referenced
this pull request
Oct 29, 2024
…s" (#602) * Revert "Replace calls to deprecated inject() with direct factory calls (#587)" This reverts commit e7827d7. * Pin dodal --------- Co-authored-by: Dominic Oram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the unit tests after the deprecation of
inject()see DiamondLightSource/dodal#845
merged in PR
DiamondLightSource/dodal#854