Skip to content

Commit

Permalink
update readme and env
Browse files Browse the repository at this point in the history
  • Loading branch information
d-perl committed Nov 27, 2024
1 parent f2abbaa commit f41b3ed
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 44 deletions.
56 changes: 13 additions & 43 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,50 +1,20 @@
# React + TypeScript + Vite
# Prototype web gui, for I24 serial

This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.
## Installation

Currently, two official plugins are available:
Currently this relies on a branch of cs-web-lib. Clone that repository, and run

- [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/README.md) uses [Babel](https://babeljs.io/) for Fast Refresh
- [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh

## Expanding the ESLint configuration

If you are developing a production application, we recommend updating the configuration to enable type aware lint rules:

- Configure the top-level `parserOptions` property like this:

```js
export default tseslint.config({
languageOptions: {
// other options...
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
tsconfigRootDir: import.meta.dirname,
},
},
})
```bash
git checkout expose_hooks
npm install
npm run rollup
npm pack
```

- Replace `tseslint.configs.recommended` to `tseslint.configs.recommendedTypeChecked` or `tseslint.configs.strictTypeChecked`
- Optionally add `...tseslint.configs.stylisticTypeChecked`
- Install [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) and update the config:
and copy the generated .tgz file over to this repo

```js
// eslint.config.js
import react from 'eslint-plugin-react'
then here run `npm install` and also run it again on the tarball of cs-web-lib. this avoids the issue of ending up with multiple copies of react due to linked dependencies (https://react.dev/warnings/invalid-hook-call-warning#duplicate-react)

export default tseslint.config({
// Set the react version
settings: { react: { version: '18.3' } },
plugins: {
// Add the react plugin
react,
},
rules: {
// other rules...
// Enable its recommended rules
...react.configs.recommended.rules,
...react.configs['jsx-runtime'].rules,
},
})
```
## Gotchas

To connect to the Diamond PVWS instance at `pvws.diamond.ac.uk` the environment variables `VITE_PVWS_SOCKET` and `VITE_PVWS_SSL` must be set to the URL and `"true"` respectively. This is in the file `.env`. Note that the value must be the string "true"
2 changes: 1 addition & 1 deletion vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import react from "@vitejs/plugin-react-swc";
// https://vite.dev/config/
export default defineConfig({
plugins: [react()],
define: { "process.env": { VITE_PVWS_SOCKET: "pvws.diamond.ac.uk", VITE_PVWS_SSL: true } },
define: { "process.env": { VITE_PVWS_SOCKET: "pvws.diamond.ac.uk", VITE_PVWS_SSL: "true" } },
});

0 comments on commit f41b3ed

Please sign in to comment.