New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to singla tools #153

Merged

noemifrisina merged 1 commit into main from tidy-up-singla

Dec 6, 2023

Collaborator

noemifrisina commented Dec 6, 2023

No description provided.


          Add tests

b2c3bef

github-advanced-security bot found potential problems

View reviewed changes

src/nexgen/tools/ED_tools.py

@@ @@ -208,7 +206,7 @@ @@
                   return start_time
-              def extract_from_SINGLA_master(master: Path | str) -> Dict[str, Any]:
+              def extract_detector_info_from_master(master: Path | str) -> Dict[str, Any]:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

noemifrisina merged commit f01357e into main

2 checks passed

noemifrisina deleted the tidy-up-singla branch

December 6, 2023 10:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet