Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AbortAll and KillAll for PowerPMAC #112

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix AbortAll and KillAll for PowerPMAC #112

merged 1 commit into from
Oct 27, 2023

Conversation

LeandroMartinsdS
Copy link
Contributor

@LeandroMartinsdS LeandroMartinsdS commented Oct 27, 2023 •
edited
Loading

Fix wrong command passed to PowerPMAC checking the cid number, and using the proper command for each case:

  • PowerPMAC: &*abort and #*kill
  • TurboPMAC: '\x01and\x0b`

@LeandroMartinsdS LeandroMartinsdS linked an issue Oct 27, 2023 that may be closed by this pull request
StopAll and KillAll forces reconnection for Power PMAC #109
Closed
@LeandroMartinsdS LeandroMartinsdS changed the title Add cid check for AbortAll and KillAll in writeInt32 Fix AbortAll and KillAll for PowerPMAC Oct 27, 2023
JamesOHeaDLS
JamesOHeaDLS approved these changes Oct 27, 2023
View reviewed changes
Copy link

@JamesOHeaDLS JamesOHeaDLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@LeandroMartinsdS LeandroMartinsdS merged commit 1c297c4 into dls-master Oct 27, 2023
@LeandroMartinsdS LeandroMartinsdS deleted the 109-Fix_KillAll_StopAll branch October 27, 2023 14:45
@LeandroMartinsdS LeandroMartinsdS added this to the R2-6-1 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesOHeaDLS JamesOHeaDLS JamesOHeaDLS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R2-6-1
Development

Successfully merging this pull request may close these issues.

StopAll and KillAll forces reconnection for Power PMAC
2 participants
@LeandroMartinsdS @JamesOHeaDLS