Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motor off update cs axes #116

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Motor off update cs axes #116

merged 2 commits into from
Nov 13, 2023

Conversation

LeandroMartinsdS
Copy link
Contributor

Reviewing #107

Have changed some variables/method names for better clarity, and corrected some formatting inconsistency.

guirodrigueslima and others added 2 commits October 30, 2023 13:42
@guirodrigueslima @LeandroMartinsdS
Update CS axes when motor OFF changes
30dc0a2 
The CS axes are updated when any motor in the same CS has the OFF
changed
@LeandroMartinsdS
Make formatting consistent
0e6f03c 
Rename variables
@LeandroMartinsdS LeandroMartinsdS mentioned this pull request Nov 13, 2023
Closed
@LeandroMartinsdS LeandroMartinsdS merged commit b19a694 into dls-master Nov 13, 2023
@LeandroMartinsdS LeandroMartinsdS deleted the motor_Off_Update_CsAxes branch November 13, 2023 11:29
@guirodrigueslima
Copy link
Contributor

Thanks @LeandroMartinsdS

@LeandroMartinsdS LeandroMartinsdS added this to the R2-6-1 milestone Nov 15, 2023
LeandroMartinsdS added a commit that referenced this pull request Jan 15, 2024
@LeandroMartinsdS
Revert "Merge pull request #116 from dls-controls/motor_Off_Update_Cs…
0a54597 
…Axes"

These changes cause a segmentation fault during the IOC boot under certain conditions.

This reverts commit b19a694, reversing changes made to 457c2c8.
@LeandroMartinsdS LeandroMartinsdS mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R2-6-1
Development

Successfully merging this pull request may close these issues.
2 participants
@LeandroMartinsdS @guirodrigueslima