Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy dependency to pyproject.toml if selected #129

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add mypy dependency to pyproject.toml if selected #129

merged 2 commits into from
Mar 11, 2024

Conversation

coretl
Copy link
Contributor

@coretl coretl commented Mar 8, 2024

Fixes #127

@coretl coretl requested a review from joeshannon March 8, 2024 17:15
joeshannon
joeshannon approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@joeshannon joeshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know you asked me to take a look but I hadn't had time yet. Have tested this and it looks good.

@coretl
Copy link
Contributor Author

coretl commented Mar 11, 2024

Sorry I know you asked me to take a look but I hadn't had time yet. Have tested this and it looks good.

No problem, I was in the code base anyway so was easy to add...

@coretl coretl merged commit 72dc363 into main Mar 11, 2024
12 checks passed
@coretl coretl deleted the mypy-dep-fix branch March 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeshannon joeshannon joeshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing mypy dependency
2 participants
@coretl @joeshannon