Added the dev script setup #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 3 3
Lines 172 172
=======================================
Hits 145 145
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
… it not fitting flake8
… it not fitting flake8
… it not fitting flake8
DominicOram
requested changes
Dec 20, 2022
There was a problem hiding this comment.
This looks good, can we:
- Add the pre-commit yaml as in https://github.com/dls-controls/tickit-devices/pull/24/files?
- Install the hooks in the dev_env script
- Update the README
Comment on lines
+24
to
+25
| - name: Checkout Artemis | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Should: This isn't artemis
Comment on lines
+7
to
+8
| # Run every Monday at 8am to check latest versions of dependencies | ||
| - cron: "0 8 * * WED" |
There was a problem hiding this comment.
Should: This comment disagrees with the cron job
|
@evalott100 This may be solved now by #32 |
|
@abbiemery Yep, all it would be adding is the .sh to do the pip venv installation which I think is unnecessary anyway. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
@DominicOram I added the dev environment script, This comes with a few warnings (e.g it wants a pyproject.toml and Distutils is imported before setup tools). Code tests pass, and tickit devices run fine. Idk if you want to fix the warnings here or make it a separate PR?