Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires importlib_metadata>=4.6 for tests #1127

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jun 13, 2024

Only for python_version<3.10

Otherwise one test is failing for these python versions

@getzze
Copy link
Collaborator Author

getzze commented Jun 13, 2024

Eventually we could use a compat.py file like babelfish

@ptrcnull
Copy link
Collaborator

IMHO we're not gonna have enough cases like this to make it a separate file, a few inline ifs should be alright

@getzze getzze mentioned this pull request Jun 13, 2024
@getzze getzze merged commit 233f0b7 into Diaoul:develop Jun 13, 2024
@getzze getzze deleted the bump-importlib branch July 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants