Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating thumbnails throws an error in latest nightly #1150

Closed
okaros opened this issue Jan 1, 2025 · 1 comment
Closed

Regenerating thumbnails throws an error in latest nightly #1150

okaros opened this issue Jan 1, 2025 · 1 comment

Comments

@okaros
Copy link
Contributor

okaros commented Jan 1, 2025

LRR Version and OS
LRR Docker Nightly

Bug Details
It looks like in the thumbnail generation rework for issue #1142 extract_thumbnail() was updated to take five arguments, but the call in regen_all_thumbnails() in Minion.pm was overlooked and still uses four arguments instead. (Thank you for that fix btw, it's working well)

Matching Logs
When hitting the "Regenerate all Thumbnails" button, errors like these are printed on stdout:

[Minion] [debug] Regenerating for 5c43e939d16a8655c434da328713cac9af9e3668...
[Minion] [warn] Error while generating thumbnail: Too few arguments for subroutine 'LANraragi::Utils::Archive::extract_thumbnail' (got 4; expected 5) at /home/koyomi/lanraragi/script/../lib/LANraragi/Utils/Minion.pm line 151.

[Minion] [debug] Regenerating for dccf87078ca09bb027058dfec6847b700554f8dd...
[Minion] [warn] Error while generating thumbnail: Too few arguments for subroutine 'LANraragi::Utils::Archive::extract_thumbnail' (got 4; expected 5) at /home/koyomi/lanraragi/script/../lib/LANraragi/Utils/Minion.pm line 151.

[Minion] [debug] Regenerating for bd21fdee9b95923c0ff2bb3ede4f9ad105a56e9f...
[Minion] [warn] Error while generating thumbnail: Too few arguments for subroutine 'LANraragi::Utils::Archive::extract_thumbnail' (got 4; expected 5) at /home/koyomi/lanraragi/script/../lib/LANraragi/Utils/Minion.pm line 151.

[Minion] [debug] Regenerating for fd0484edbc66a56ee98f28d745b8096c20452d3b...
[Minion] [warn] Error while generating thumbnail: Too few arguments for subroutine 'LANraragi::Utils::Archive::extract_thumbnail' (got 4; expected 5) at /home/koyomi/lanraragi/script/../lib/LANraragi/Utils/Minion.pm line 151.

[Minion] [debug] Regenerating for f05898a3caea4d67b92c410049006375b3929ad5...
[Minion] [warn] Error while generating thumbnail: Too few arguments for subroutine 'LANraragi::Utils::Archive::extract_thumbnail' (got 4; expected 5) at /home/koyomi/lanraragi/script/../lib/LANraragi/Utils/Minion.pm line 151.
@Difegue
Copy link
Owner

Difegue commented Jan 2, 2025

That is correct. Thanks for the report!

@Difegue Difegue closed this as completed Jan 2, 2025
Difegue added a commit that referenced this issue Jan 2, 2025
Difegue added a commit that referenced this issue Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants