Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Middleware to use trailing path #175

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Update Middleware to use trailing path #175

merged 1 commit into from
Dec 16, 2018

Conversation

espcoder
Copy link
Contributor

We are using a url with a dynamic path part which is not known at service startup time. There are too many variations of the path to register them all as service endpoints. This PR changes the middleware Invoke to compare the path to a service endpoint using only the trailing part of the path.

Example:
Url: http://localhost/AppName/DynamicPathPart/Service.asmx
compare on trailing path: "/Service.asmx"
instead of path: "/DynamicPathPart/Service.asmx"

Url: http://localhost/AppName/DynamicPathPart/Service.asmx
compare on trailing path: "/Service.asmx"  
instead of path: "/DynamicPathPart/Service.asmx"
@kotovaleksandr kotovaleksandr merged commit 5fc5822 into DigDes:master Dec 16, 2018
@espcoder espcoder deleted the match-trailing-path branch December 17, 2018 17:45
@kotovaleksandr
Copy link
Member

@espcoder i understand what problem you solve, but PR break common behavior (for example #187).
Please, add setting or change code to solve your problem and save previous behavior with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants