Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today SoapCore only supports encoding of
utf-8, utf-16 (+le/be)
, and not any legacy likeISO-8859-1
.So when starting the SoapCore consuming part like this:
Will end in a exception, since
XmlDictionaryReader.CreateTextReader
only support the mentioned encodings.This PR makes it so it falls back to
XmlReader
which has no encoding restrictions, and thereby support ISO-8859-1.