Specify BindingName and PortName per SoapMessageEncoder #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncoder. added tests to verify both this behavior and default behavior
Merged
andersjonsson
deleted the
specify-binding-and-portname-per-messageencoder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to set custom bindingname and portname per SoapMessageEncoder.
added tests to verify both this behavior and default behavior
A client uses an integration platform that rebuilds the service reference from wsdl as soon as they compile their integration project. To avoid errors in those cases we need the ability to set BindingName and PortName explicitly, so that it's identical with the old Api.
Since you need different names for each soap version you support I thought the most straightforward solution would be to add bindingname and portname to SoapMessageEncoderOptions.