Only append schemaLocation when XsdFolder defined #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, schemaLocations will be appended that do not actually exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding XSD's are optional, but the current behavior of the "Using with external WSDL / XSD schemas" feature will always append a schemaLocation to "importOrIncludeNode(s)," even when XSD's are explicitly omitted. The value produced for the schemaLocation attribute is then invalid and looks something like http://localhost:5000/Service.asmx?xsd&name= which is invalid.
This change proposes only appending schemaLocation when we know at least the schemaLocation directory has been defined by the client.