-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Optional Custom Serializer in Soap Core #973
Conversation
Please fix the build errors in the test project and I will take a look. |
And thank you for the PR 😄 |
Hi, Fixed build error(s) for Middleware in test proj and added new test case for Serializer. Let me know if there is anything to add. |
There are plenty of failing tests. Please take a look and fix that |
----Added delegate To Get the Custom Service if Added Into SoapOptions ----Added Exception if Custom Impl NOT Found
Fixed! and Updated Docs for Latest Code. |
@andersjonsson any comments? |
I think it looks fine. I would like you to change the name though. |
Changed from |
I think I'm ready to merge this. There are conflicts in SoapCoreOptions.cs that has to be resolved first though |
@andersjonsson any news on this? |
The conflicts are still there. Please resolve them, then I can merge this branch |
@andersjonsson Resolved the conflicts and updated the code. Could you look and let me know if you need anything else? |
Thank you! |
Added Custom Soap Core Serializer using DI
If Custom Soap Core Serializer NOT found, Then Fall back for default Soap Core Serializer