-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DI] Resolve IMessageInspector2 Using Scope Resolver #982
fix: [DI] Resolve IMessageInspector2 Using Scope Resolver #982
Conversation
----Added delegate To Get the Custom Service if Added Into SoapOptions ----Added Exception if Custom Impl NOT Found
----IMessageInsector2 is being Added as Scope Service, However, it is being resolve as Sington Service
Could you please update your branch from the latest "develop"? Needed to fix some things to make CI work |
The CI/CD test for the pull request is encountering a fetch error. Would you mind re-running the test to resolve this issue? Here is the specific fetch command that is causing the issue: |
Please update your branch with the latest "develop". I've fixed the issues there |
Thanks, I have pulled the latest changes from the 'develop' branch. Hope this works! |
I think you pulled the changes from your own develop-branch, including the code for custom serializers. |
When I look at the code for resolving IMessageInspector2 I'm not sure that the changes make sense. Since the serviceProvider is passed in to each invoke it should be resolved as registered. I suppose you have an indication that this isn't the case. What is the issue you are running into? |
Hi @andersjonsson , Referring to commit [Git Hub Commit#58afbb9]](58afbb9), The As you mentioned, serviceProvider is passed into each invoke it should be resolved as registered. However, It is noted that the Have changed from singleton di resolve to scope di resolve in |
I hope you're doing well. I wanted to check in and see if you've had a chance to look into the issue I sent over earlier. If you need any additional information, please let me know. Regards; |
----IMessageInsector2 is being Added as Scope Service, However, it is being resolve as Sington Service