WSDL for XmlSerializer: Fix invalid ArrayOfString schema #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the special if-condition for "string", which does not make sense, because it does not correspond to the actual XML that is generated by the XmlSerializer. Afterwards, the fields _arrayToBuild and _buildArrayTypes are not needed anymore, so I have removed them. The test CheckStringArrayNameWsdl() can only be performed for the DataContractSerializer now, because the complexType does not have an element inside it anymore. Fixes DigDes#996
vidrenning
force-pushed
the
liststring2
branch
from
553e9fe to
ef223ff
Compare
|
Thank you! |
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the special if-condition for "string", which does not make sense, because it does not correspond to the actual XML that is generated by the XmlSerializer. Afterwards, the field _arrayToBuild is not needed anymore, so I have removed it.
The test CheckStringArrayNameWsdl() can only be performed for the DataContractSerializer now, because the complexType does not have an element inside it anymore.
Fixes #996