Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EEG digital Score example #77

Closed
wants to merge 4 commits into from
Closed

Added EEG digital Score example #77

wants to merge 4 commits into from

Conversation

craigvear
Copy link
Contributor

Added an eeg brainwave reader -> realtime neoscore rendering in examples folder.

craigv added 2 commits November 20, 2022 16:12
…ser to generate realtime notation through neoscore's refresh function
…ser to generate realtime notation through neoscore's refresh function
@craigvear
Copy link
Contributor Author

Annoyingly I cannot get pre-commit to work. I have reinstalled the poetry env for Python 3.7, 3.8, 3.9 & 3.10 and get the same error (below). This is on Mac MBP (not M1) OS12.6. Pycharm 2022.2.4.

File "/usr/local/Caskroom/miniconda/base/bin/unimport", line 10, in
sys.exit(main())
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/unimport/main.py", line 60, in main
utils.get_used_packages(Import.imports, unused_imports)
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/unimport/utils.py", line 102, in get_used_packages
name = package_name_from_metadata(package)
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/unimport/utils.py", line 90, in package_name_from_metadata
return metadata(package)["Name"]
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/importlib_metadata/init.py", line 1010, in metadata
return Distribution.from_name(distribution_name).metadata
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/site-packages/importlib_metadata/init.py", line 567, in from_name
raise ValueError("A distribution name is required.")
ValueError: A distribution name is required.

@ajyoon
Copy link
Collaborator

ajyoon commented Nov 28, 2022

I've disabled the unimport check in the precommit script and reported the bug upstream. Try running the precommit script again now on this branch. (note now you'll need to use pycharm's import scrubber, which I think typically runs automatically so shouldn't be an issue?)

@craigvear
Copy link
Contributor Author

Tried pre-commit devtools.sh and then pre-commit script on other PR. devtools installed nicely. pre_commit_hook does nothing (just returns a new line in Terminal

@ajyoon
Copy link
Collaborator

ajyoon commented Nov 28, 2022

If the git hook doesn't actually run when you commit it's not installed properly. The script should always print some things to console, even if everything passes.

@craigvear
Copy link
Contributor Author

works now :)

@ajyoon
Copy link
Collaborator

ajyoon commented Dec 2, 2022

Yeah, as we discussed separately, I think this example is better kept to a separate repo because it requires external dependencies, has a separate license, and is relatively complex. Once you get it in a separate repo we can definitely highlight it here with a external_examples.md or similar file here and/or in the docs.

@ajyoon ajyoon closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants