feat: upgrade react-router to v6 in dashboard #3007
Conversation
auto-assign
bot
requested review from
guanbinrui,
jk234ert,
septs and
zhouhanseng
packages/dashboard/src/components/DashboardFrame/Navigation.tsx
Outdated
Show resolved
Hide resolved
| const renderLink = useMemo( | ||
| () => | ||
| forwardRef<HTMLAnchorElement | null, Omit<LinkProps, 'to'>>((linkProps, ref) => ( | ||
| <Link to={to} ref={ref} {...linkProps} /> | ||
| )), | ||
| [to], |
There was a problem hiding this comment.
Hmm this part is strange to me... Why not define a new Link that internally renames component props (from mui) to as props (to react-route)?
There was a problem hiding this comment.
Link does not have as props in v6
|
It looks like react-router doesn't support |
|
reopened but converted to draft. |
|
Will you continue on this before we have more routes? @nuanyang233 |
hmm, it looks like react-router doesn't solve the previously mentioned problem. I'll keep trying to replace it. |
|
Sorry, I re-tested and the problem is not that
However, Material-UI provides But they missing export it in version 36... mui/material-ui#26660 maybe we need to wait for version 38. 😂 cc @Jack-Works |
|
We have |
nuanyang233
force-pushed
the
feature/upgrade-react-router
branch
from
add7a93 to
02eb77e
Compare
|
@nuanyang233 I see the patch file is a little big. Is all that content necessary? Is it possible to do via a smaller (minimal) patch? That will be easier when we're going to upgrade. |
closes #2989