Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFTP fixes #5

Merged
merged 2 commits into from
Dec 2, 2015
Merged

TFTP fixes #5

merged 2 commits into from
Dec 2, 2015

Conversation

OlegHahm
Copy link

@OlegHahm OlegHahm commented Dec 1, 2015

In combination with RIOT-OS#4189 these fixes make Linux as a client and RIOT as a server working. Haven't tested the other way around.

@DipSwitch
Copy link
Owner

I don't realy follow because when I test it on my board with Linux as client and/or server it seems to work, altough I still have IPHC disabled as stated on the Wiki page.

Don't really like the searching trough a link list idea but if there is no other way :)
I'll test it tomorrow and merge and merge and squash it into the pull request.

Thanks for the help :)

@OlegHahm
Copy link
Author

OlegHahm commented Dec 1, 2015

altough I still have IPHC disabled as stated on the Wiki page

Interesting hint. The compression could be indeed a cause for the reordering IMO. Which Wiki page are you referring to?

Don't really like the searching trough a link list idea

Well, as @authmillenon wrote in the other PR: that's the way it is done in most places in the stack and remember that this list contains almost never more than 4 or 5 elements.

@DipSwitch
Copy link
Owner

DipSwitch commented Dec 2, 2015 via email

DipSwitch added a commit that referenced this pull request Dec 2, 2015
@DipSwitch DipSwitch merged commit c1398b8 into DipSwitch:tftp_client Dec 2, 2015
@OlegHahm OlegHahm deleted the tftp_fixes branch December 2, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants