FIXED Issue 69: Theme-box is now on the Home page header. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for html-github ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I found this problem on it. |
|
I just pushed a change to the issue-69 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The theme-box has been moved to the header and no longer overlap the tutorial boxes, but the theme-box is still unique to the Home page.
Related Issue
Resolves the primary problem described in Issue #69.
Screenshots of changes made
Home Page before changes
Home Page after changes
Description of code changes
Initially, I moved the theme-box's HTML from the Home page's
index.htmlfile to theinclude\header.htmlfile, as a list item within the<div class="menu">element.This resulted in the theme-box appearing on the header on each page. However, the theme-box lost the ability to actually change the website's theme. The functionality within
app.jsis not applied to the theme-box if the theme-box is included from a separate HTML file via theinclude-htmlattribute on an element (e.g.<div include-html="include\header.html"></div>).So, I moved the HTML code from the
include\header.htmlfile into the Home page'sindex.htmlfile and discarded the changes I made to theheader.htmlfile (as such, theheader.htmlfile does not have any changes committed to it).I tested this version and the theme-box appears on the header, thus it does not overlap tutorial boxes anymore (as described in issue #69) and it works correctly (being able to change the theme as intended).
Note that: with this method, the theme-box only appears on the Home page and is not available on the individual tutorial pages.