Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is soo needed #28

Merged
merged 1 commit into from
Dec 20, 2022
Merged

this is soo needed #28

merged 1 commit into from
Dec 20, 2022

Conversation

CASPERg267
Copy link
Contributor

No description provided.

@Mechite
Copy link
Contributor

Mechite commented Dec 16, 2022

This does not contribute anything useful to the project as the possible category values can only be as seen in that if statement. The formatting change above where you added a line break to the if statement was likely incidental as you would've probably cloned it before that had changed.

If there is a specific reason why you made this change, ie there is some reason why the values would only match case insensitive, please provide it and maybe make changes in the other files where these kind of assertions are made, such as the feed handler.

tl;dr: From my limited knowledge of this codebase, I can safely make the assumption that this change has no effect, if anything a negative effect.

@CASPERg267
Copy link
Contributor Author

about the formatting maybe i wasn't on latest, i didn't mean that
and i made changes to the match case to be more specific cause it didn't see my owner category because its "Owner" instead of owner, so this works and it detects it to make the cmd Handler more efficient

Copy link
Member

@iMidnights iMidnights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful as not everyone uses lowercase to name their categories

@iMidnights iMidnights added the enhancement New feature or request label Dec 18, 2022
@breftejk breftejk merged commit 8d1ec80 into Discord-Dashboard:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants