Upgrade to 3.0 and remove jquery usage

[snewcomer]

Still got some work to do here. Previous implementation for scroll listeners did something to the effect of scroll.elementId whereas now it just simply listens for scroll. Need to look into if this could break anything.

• upgrade to 3.0
• replace usage of jquery
• properly remove jquery

Closes #118

[snewcomer]

Based on eslint's rule no-function-prototype-extensions

[snewcomer]

I'm not totally sure of the implications of this. It wouldn't be good if the removeEventListener matching algorithm didn't match....so maybe I should put the callback as a method on the mixin instead of repeating it in the addEventListener callback.

[snewcomer]

Also concerned about the use of elementId here. Perhaps this was there to solve a use case where this mixin was used on many components on a page. So potentially, with this PR, there are multiple listeners on the window object.

[bkoval]

I'm getting Uncaught DOMException: Failed to construct 'IntersectionObserver': rootMargin must be specified in pixels or percent. When trying out the branch -> this is due to _viewportTolerance.left and .right being undefined. (newest desktop Chrome emulating Nexus 6p).

[snewcomer]

@bkoval What do you have set for the viewportTolerance, if anything? The browser automated tests aren't showing anything. Just tried this branch out as well on 4200.

Note: one thing I did notice is that we aren't allowing users to specify %'s for the viewport tolerance 😱

https://github.com/DockYard/ember-in-viewport/blob/master/addon/mixins/in-viewport.js#L104

[bkoval]

@snewcomer I am just setting top and bottom. Could it be that on master ember-in-viewport uses defaults in such case?

[snewcomer]

@bkoval would you mind pasting your viewportTolerance config?

[bkoval]

Sure:

const viewportTolerance = 1000;
  
this.set('viewportTolerance', {
    top: viewportTolerance,
    bottom: viewportTolerance
});

[snewcomer]

@bkoval Welp, you are completely correct. Sry about that. Put a PR in to fix. In the meantime, if your config looked like this, it should work. Thanks for reporting this bug!

this.set('viewportTolerance', {
    top: viewportTolerance,
    bottom: viewportTolerance,
    right: 0,
    left: 0
});

[snewcomer]

Tested this branch out on our app and works 👍 . Anybody else wanna give it a go?