Allow root on static admin to have multiple keys
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root scrollable area can have multiple elements with different observer options. To prevent the first element"s options from overriding the rest of the page, we need to ensure that when we want to find a potential match for an element, that we compare the observer options andd only reuse the instance of the IntersectionObserver if the element shares the same root and same observer options
snewcomer
force-pushed
the
sn/sharing-same-root
branch
from
c77ee36 to
c362f7f
Compare
snewcomer
force-pushed
the
sn/sharing-same-root
branch
2 times, most recently
from
4a7181b to
58ceec4
Compare
snewcomer
force-pushed
the
sn/sharing-same-root
branch
from
58ceec4 to
9c5090f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root scrollable area can have multiple elements with different observer options. To prevent the first element's options from overriding the rest of the observers in the static administrator (cache to reuse intersection observer instances), we need to ensure that when we want to find a potential match for an element, that we compare the to be added element's observer options and only reuse the instance of the IntersectionObserver iff the element shares the same root and same observer options