Register the Component's elementId along with it's rAF call #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables `viewportSpy: false` to work when rAF is enabled. The Mixin essentially stores an object with elementIds as keys for all Objects with the Mixin, and with their respective requestAnimationFrame ids as values. This allows for `#_unbindListeners` to cancel the appropriate animation frame, based on that Component's elementId.
poteto
added a commit
that referenced
this pull request
Apr 16, 2015
Register the Component's elementId along with it's rAF call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
This commit enables
viewportSpy: falseto work when rAF is enabled.The Mixin essentially stores an object with elementIds as keys for all Objects
with the Mixin, and with their respective requestAnimationFrame ids as
values. This allows for
#_unbindListenersto cancel the appropriateanimation frame, based on that Component's elementId.