General refactor, fire Evented hooks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7. This commit is a general factor of the Mixin for performance improvements. The Mixin now fires actual 'hooks', named `didEnterViewport` and `didExitViewport`, which you can use in your app in place of observers. For example, ```js export default Ember.Component.extend(InViewportMixin, { handleDidEnterViewport: on('didEnterViewport', function() { console.log('entered'); }), handleDidExitViewport: on('didExitViewport', function() { console.log('exited'); }) }); ``` Full changelog: - refactored `_setViewportEntered` - now triggers Events - removed unnecessary Ember.warn - updated debounce method to use fat arrow - explicitly set `viewportEntered` when removing viewportSpy to prevent race conditions setting it to false - renamed `_viewportDidEnter` to `_unbindIfEntered` which is more correct semantically - removed unnecessary var declaration - removed redundant initial call to `_setViewportEntered` - removed $viewportCachedEl in favour of using `get(this, 'element')`
|
👍 |
poteto
added a commit
that referenced
this pull request
Apr 24, 2015
General refactor, fire Evented hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7. This commit is a general refactor of the Mixin for performance improvements. The Mixin now fires actual 'hooks', named
didEnterViewportanddidExitViewport, which you can use in your app in place of observers. For example,Full changelog:
_setViewportEnteredviewportEnteredwhen removing viewportSpy to prevent race conditions setting it to false_viewportDidEnterto_unbindIfEnteredwhich is more correct semantically_setViewportEnteredget(this, 'element')