Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waves - update plugin to latest version #5779

Open
kkaplita opened this issue Mar 29, 2018 · 6 comments
Open

Waves - update plugin to latest version #5779

kkaplita opened this issue Mar 29, 2018 · 6 comments

Comments

@kkaplita
Copy link

kkaplita commented Mar 29, 2018

Waves effects in Materialize are powered by Waves (http://fian.my.id/Waves). Version included in materialize library is 0.6.4. Can you update it to latest 0.7.6?

@kkaplita kkaplita changed the title Waves - update library to latest version Waves - update plugin to latest version Mar 29, 2018
@Dogfalo
Copy link
Owner

Dogfalo commented Mar 29, 2018

What functionality from the newer version do you need?

@ncovercash
Copy link
Contributor

It looks like there are many benefits, per the changelog: https://github.com/fians/Waves/releases

  • Add support for co-existing with some other things users may use
  • Remove unused transition propertied
  • Don't do the wave effect while scrolling (this one is a bug I've faced many times in my own applications)
  • Fixes errors on rapid clicking
  • Don't ripple when the disabled property is set
  • Don't use z-index in CSS
  • And, to top it off, fix a memory leak

@ncovercash
Copy link
Contributor

I wouldn't think any of this would cause issues

@kkaplita
Copy link
Author

@smileytechguy said about benefits. And I think newer version is better in latest Materialize. you should take care of such details.

@Niels-Be
Copy link

Niels-Be commented Apr 12, 2018

I would really appreciate this, too.

In my use case I need to triggering the waves effect from code (Waves.ripple() introduced in 0.7.0).

In my application I replaced the css and js code and added in line 30:

document.addEventListener('DOMContentLoaded', function () {
      window.Waves.init();
}, false);

(This was previously in the end of the file)

This worked for me. However I have not tested all components.

Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 5, 2018
This is 99% origignal Waves.js code.
The only thing added was the initialisation on dom load in line 31.
Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 5, 2018
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
@woyehenni
Copy link

@Dogfalo
Could you merge this PR please. thanks.
I need the latest Waves lib to fix my problem.

Niels-Be added a commit to Niels-Be/materialize that referenced this issue Aug 10, 2020
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
JayDijkstra pushed a commit to JayDijkstra/materialize that referenced this issue Mar 7, 2021
This is 99% original Waves.js code.
The only thing added was the initialization on DomLoad in line 31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants