FIX missing entity filter to customize ticket dictionaries by entity #26001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2023
Closed
eldy
reviewed
Sep 25, 2023
htdocs/ticket/class/ticket.class.php
Outdated
| @@ -1242,7 +1242,8 @@ public function loadCacheTypesTickets() | |||
|
|
|||
| $sql = "SELECT rowid, code, label, use_default, pos, description"; | |||
| $sql .= " FROM ".MAIN_DB_PREFIX."c_ticket_type"; | |||
| $sql .= " WHERE active > 0"; | |||
| $sql .= " WHERE entity = ".getEntity('c_ticket_type'); | |||
There was a problem hiding this comment.
With getEntity in a SQL, you must use
...entity IN (".getEntity().")"
There was a problem hiding this comment.
@eldy not for dictionary table, getEntity return 1 if all entities use the same dictionary or the current entity if the dictionary is personalized
There was a problem hiding this comment.
So even in this case, we can use the IN.
For a more uniform code, it should be better to have IN everywhere for getEntity, even if at execution the in become a IN (1)
eldy
added
the
PR to fix - See feedback in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX add field "entity" only in $tabfieldinsert