Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snippets to use correct placeholder syntax #976

Merged
merged 1 commit into from
May 22, 2017

Conversation

jrieken
Copy link
Contributor

@jrieken jrieken commented May 22, 2017

Many snippets here use the TM variable syntax instead of the placeholder/tabstop syntax. The snippet parser in VS Code has now become more strict any will interpret ${foo} as variable, not as placeholder anymore. This PR updates many snippets to use the correct placeholder syntax, e.g ${1:foo}. For reference see: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax. Related to microsoft/vscode#26733

Many snippets here use the TM variable syntax instead of the placeholder/tabstop syntax. The snippet parser in VS Code has now become more strict any will interpret `${foo}` as variable, not as placeholder anymore. This PR updates many snippets to use the correct placeholder syntax, e.g `${1:foo}`. For reference see: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax. Related to microsoft/vscode#26733
@DonJayamanne DonJayamanne reopened this May 22, 2017
@DonJayamanne DonJayamanne merged commit 370d5be into DonJayamanne:master May 22, 2017
DonJayamanne pushed a commit that referenced this pull request Mar 7, 2018
Some are runtime errors (e.g. `break` outside of a loop), while others are just warnings (e.g. unused imports).

Reverts part of 7894ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants