Resolve the error - Doppler Error: exec: "x": cannot run executable found relative to current directory' #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanoogian
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Starting with Go 1.19 the Go team put in some guardrails surrounding
exec.Commandandexec.LookPathwhere including the current path was considered undesirable behaviour (https://pkg.go.dev/os/exec@master#hdr-Executables_in_the_current_directory) . This PR aims to restore pre 1.19 behaviour.The reasoning behind this is there are scripts and systems that do exist (and are created even today) that rely on this behaviour. For something such as Doppler which is essentially injecting the secrets and calling a shell (that doesn't restrict this behaviour), these guardrails seem somewhat irrelevant.
This would resolve #415 .