Remove references from analyzers to Microsoft.CodeAnalysis.Workspaces #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Helper classes which depend on Microsoft.CodeAnalysis.Workspaces are located in the WorkspaceHelpers namespace. * Helper classes which do not depend on Microsoft.CodeAnalysis.Workspaces are located in other namespaces.
Current coverage is
|
|
👍 Changes look good to me. What a nasty kind of dependency problems. Do you think its worth to have some unit tests that will verify this kind of dependency? |
This change allows us to ensure analyzers never contain references to Microsoft.CodeAnalysis.Workspaces.
Now that two assemblies are used, separation of the namespaces is no longer required.
|
@vweijsters I took a more extreme approach with the two commits I just added. With two assemblies, it is now impossible for our analyzers to reference types that would cause this problem. |
|
👍 |
sharwell
added a commit
that referenced
this pull request
Oct 23, 2015
Remove references from analyzers to Microsoft.CodeAnalysis.Workspaces
This was referenced Feb 16, 2018
This was referenced Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzers are not allowed to directly or indirectly reference the Microsoft.CodeAnalysis.Workspaces assembly. This means analyzers cannot reference members of code fix providers.
TokenSpacingCodeFixProviderinside of various analyzers.