Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations #1683

Merged
merged 7 commits into from
Oct 24, 2015
Merged

Conversation

sharwell
Copy link
Member

This change reduces the number of allocations which are required to execute HandleCompilationStart for the various analyzers. These calls are made many times while users are working in the IDE, so the benefits of this change are most visible there. The potential benefit is at least hundreds of allocations each time the user makes a change while typing in the editor.

Currently the work is complete for documentation and layout rules, and partially complete for the remaining rules.

@codecov-io
Copy link

Current coverage is 79.37%

Merging #1683 into master will increase coverage by +0.01% as of bc96df1

@@            master   #1683   diff @@
======================================
  Files          545     545       
  Stmts        32203   32316   +113
  Branches      8974    8975     +1
  Methods          0               
======================================
+ Hit          25557   25652    +95
- Partial       5211    5213     +2
- Missed        1435    1451    +16

Review entire Coverage Diff as of bc96df1

Powered by Codecov. Updated on successful CI builds.

@pdelvo
Copy link
Member

pdelvo commented Oct 24, 2015

👍

@sharwell sharwell added this to the 1.0.0 Beta 15 milestone Oct 24, 2015
sharwell added a commit that referenced this pull request Oct 24, 2015
@sharwell sharwell merged commit 49b706d into DotNetAnalyzers:master Oct 24, 2015
@sharwell sharwell deleted the reduce-allocations branch October 24, 2015 23:44
@sharwell sharwell added the fixed label Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants