Added support for CSharp8 tests and fixed #2927 #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharwell I created this PR to add support for CSharp8. As part of that I had to upgrade Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit. As a result of this a lot of tests with included documentation fail now. Do you have any pointers on what could have caused that? |
|
I'll take a look |
|
Let's try again after dotnet/roslyn-sdk#307 is merged. |
… remaining issues
Codecov Report
@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
- Coverage 97.43% 96.71% -0.72%
==========================================
Files 778 702 -76
Lines 100192 93569 -6623
Branches 3266 3266
==========================================
- Hits 97622 90496 -7126
- Misses 1702 2168 +466
- Partials 868 905 +37 |
Codecov Report
@@ Coverage Diff @@
## master #2936 +/- ##
==========================================
- Coverage 97.43% 97.43% -0.01%
==========================================
Files 778 780 +2
Lines 100192 100224 +32
Branches 3266 3266
==========================================
+ Hits 97622 97653 +31
- Misses 1702 1703 +1
Partials 868 868 |
|
Works now 👍 |
sharwell
reviewed
Apr 16, 2019
...nalyzers/StyleCop.Analyzers/SpacingRules/SA1011ClosingSquareBracketsMustBeSpacedCorrectly.cs
Show resolved
Hide resolved
|
@vweijsters I believe you'll need to update opencover-report.ps1 to run the new test project in AppVeyor. |
sharwell
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2927