merge #6
Merged
merge #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add glue_version argument reference
Add state migration for r/aws_dx_gateway_association.
replace arn tests with testAccMatchResourceAttrRegionalARN function
… before testing 'recovery_point_tags' attribute.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 120m
=== RUN TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT TestAccAwsBackupPlan_basic
=== CONT TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT TestAccAwsBackupPlan_disappears
=== CONT TestAccAwsBackupPlan_withRules
=== CONT TestAccAwsBackupPlan_withLifecycle
=== CONT TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (19.33s)
--- PASS: TestAccAwsBackupPlan_basic (20.82s)
--- FAIL: TestAccAwsBackupPlan_withRecoveryPointTags (26.61s)
testing.go:569: Step 1 error: errors during apply:
Error: error updating Backup Plan (1104fa3b-5714-4c2e-9776-78660300ee6b): InvalidParameter: 2 validation error(s) found.
- missing required field, UpdateBackupPlanInput.BackupPlan.Rules[0].RuleName.
- missing required field, UpdateBackupPlanInput.BackupPlan.Rules[0].TargetBackupVaultName.
on /tmp/tf-test417192270/main.tf line 6:
(source code not available)
--- PASS: TestAccAwsBackupPlan_withRules (47.10s)
--- PASS: TestAccAwsBackupPlan_withTags (47.82s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (60.07s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 60.128s
FAIL
GNUmakefile:24: recipe for target 'testacc' failed
make: *** [testacc] Error 1
Import test refactor for athena named queries
import test lintignores for ACM cert tests
import test lintignores for API gateway resources
Import test refactor for launch resources
Import test refactor for SNS topic
Import test refactor for elasticache resources
import test lintignore for lightsail key pairs
…m-aws-aws-sdk-go-1.x Update module aws/aws-sdk-go to v1.25.21
…m renovate update
S3: support MethodNotAllowed for Object Lock Configuration
…m-aws-aws-sdk-go-1.x Update module aws/aws-sdk-go to v1.25.22
…gren/terraform-provider-aws into NSjogren-f-aws_glue_job-glue_version
Reference: #10237 (review) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSGlueJob_AllocatedCapacity (52.40s) --- PASS: TestAccAWSGlueJob_Timeout (52.61s) --- PASS: TestAccAWSGlueJob_ExecutionProperty (57.79s) --- PASS: TestAccAWSGlueJob_Description (61.93s) --- PASS: TestAccAWSGlueJob_Command (62.62s) --- PASS: TestAccAWSGlueJob_Basic (72.67s) --- PASS: TestAccAWSGlueJob_DefaultArguments (74.90s) --- PASS: TestAccAWSGlueJob_MaxRetries (81.59s) --- PASS: TestAccAWSGlueJob_GlueVersion (88.02s) --- PASS: TestAccAWSGlueJob_SecurityConfiguration (99.31s) --- PASS: TestAccAWSGlueJob_PythonShell (105.36s) --- PASS: TestAccAWSGlueJob_MaxCapacity (124.59s) ``` Output from acceptance testing in AWS GovCloud (US) (new test failure acceptable in this partition): ``` --- FAIL: TestAccAWSGlueJob_GlueVersion (34.67s) testing.go:615: Step 0 error: Check failed: Check 2/2 error: aws_glue_job.test: Attribute 'glue_version' expected "0.9", got "" --- PASS: TestAccAWSGlueJob_Command (51.17s) --- PASS: TestAccAWSGlueJob_DefaultArguments (67.58s) --- PASS: TestAccAWSGlueJob_MaxRetries (68.45s) --- PASS: TestAccAWSGlueJob_SecurityConfiguration (75.77s) --- PASS: TestAccAWSGlueJob_PythonShell (81.86s) --- PASS: TestAccAWSGlueJob_Description (86.03s) --- PASS: TestAccAWSGlueJob_MaxCapacity (95.51s) --- PASS: TestAccAWSGlueJob_Timeout (103.41s) --- PASS: TestAccAWSGlueJob_Basic (120.65s) --- PASS: TestAccAWSGlueJob_ExecutionProperty (134.29s) --- PASS: TestAccAWSGlueJob_AllocatedCapacity (143.32s) ```
Import test refactor for opsworks resources
Import test refactor for EC2 instances
Add Tag Support to Storage Gateway SMB File Share Resource
KmsKeyId support for aws_elasticache_replication_group
DrFaust92
pushed a commit
that referenced
this pull request
Jun 13, 2020
fixing broken tests for new tagging mechanism for VPC, subnet, and ro…
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: