Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: replace abbreviatedStatus setting with freely adjustable text (possibly including none) #9

Closed
GitMensch opened this issue Jan 4, 2021 · 2 comments · Fixed by #11
Closed

Idea: replace abbreviatedStatus setting with freely adjustable text (possibly including none) #9

GitMensch opened this issue Jan 4, 2021 · 2 comments · Fixed by #11
Assignees
@GitMensch

Comments

@GitMensch
Copy link
Collaborator

I've played around with this a bit and think it would be "clean" to replace the one boolean setting abbreviatedStatus by two string settings textInsertMode (default: "Insert") and textOvertypeMode (default: "Overtype").

Con for the change: likely will lead to some inconvenience for some users which will "need" to adjust the new setting and get a warning message in their settings that the old one is unknown

Pro for the change: allows people to localize (or abbreviate) as they want and to have the same result as with other editors / IDEs (for example Visual Studio shows "OVR" if active and nothing otherwise - which I'd internally set if both trimmed versions are identical [normally: empty]).

@DrMerfy Are you OK with me to do that change in master? I have 98% of the code already, only cleanup and ChangeLog is missing....
@GitMensch GitMensch self-assigned this Jan 4, 2021
@GitMensch GitMensch mentioned this issue Jan 5, 2021
Closed
@DrMerfy
Copy link
Owner

DrMerfy commented Jan 6, 2021

Sounds good to me! You are putting a lot of effort on this project, @all-contributors please add @GitMensch to the contributors :)

@allcontributors allcontributors bot mentioned this issue Jan 6, 2021
Merged
@allcontributors
Copy link

@DrMerfy

I've put up a pull request to add @GitMensch! 🎉

GitMensch added a commit to GitMensch/vscode-overtype that referenced this issue Jan 6, 2021
@GitMensch
freely adjustable label texts for status bar
eb2f87f 
fixes DrMerfy#9 and DrMerfy#5
@GitMensch GitMensch mentioned this issue Jan 6, 2021
Merged
GitMensch added a commit to GitMensch/vscode-overtype that referenced this issue Jan 6, 2021
@GitMensch
freely adjustable label texts for status bar
35c8e08 
Replaced configuration `overtype.abbreviatedStatus` by freely adjustable texts `overtype.labelInsertMode` and `overtype.labelOvertypeMode` DrMerfy#9
which allows free abbreviation, localization and also allows hiding the current state in the status bar DrMerfy#4 - replaced by new logic.

fixes DrMerfy#9 and DrMerfy#5
GitMensch added a commit to GitMensch/vscode-overtype that referenced this issue Jan 6, 2021
@GitMensch
freely adjustable label texts for status bar
6ec0733 
Replaced configuration `overtype.abbreviatedStatus` by freely adjustable texts `overtype.labelInsertMode` and `overtype.labelOvertypeMode` DrMerfy#9
which allows free abbreviation, localization and also allows hiding the current state in the status bar DrMerfy#4 - replaced by new logic.

fixes DrMerfy#9 and DrMerfy#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GitMensch GitMensch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

freely adjustable label texts for status bar GitMensch/vscode-overtype
2 participants
@GitMensch @DrMerfy