Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get metric value manipulation #26

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Remove get metric value manipulation #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2838d17
remove GetMetricValue manipulation
jannast Mar 3, 2023
464973f
fix lint
jannast Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Removed

- manipulation GetMetricValue
- manipulation SetMetricValuesWithQualityValidity
- manipulation GenerateElementsInStates
- manipulation SetOverflow
Expand Down
9 changes: 0 additions & 9 deletions src/t2iapi/metric/metric_responses.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ syntax = "proto3";
package t2iapi.metric;

import "t2iapi/basic_responses.proto";
import "t2iapi/response_types.proto";

option java_package = "com.draeger.medical.t2iapi.metric";
option java_outer_classname = "MetricResponses";
Expand All @@ -25,14 +24,6 @@ message CalibrateMetricResponse {
repeated string values = 2;
}

// Describes return value for the rpc that returns current Numeric Metric value
message MetricValueResponse {
BasicResponse result = 1; // the status of the rpc indicating whether or not it was successful
string value = 2; // string representation of the decimal value of the metric
string step_width = 3; // string representation of the decimal value of the metric value step width
PartialCodedValue unit = 4; // the metric unit, represented by a partial coded value with translation
}

// Response indicating whether a metric is computer-controlled
message IsComputerControlledResponse {
BasicResponse status = 1; // the status of the rpc indicating whether or not it was successful
Expand Down
7 changes: 0 additions & 7 deletions src/t2iapi/metric/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ service MetricService {
rpc SetMetricValuesInRange (t2iapi.metric.SetMetricValuesInRangeRequest)
returns (BasicResponse);

/*
Get the current value of the Numeric metric with the given handle.
Only values from the gui should be used (not from SDC).
*/
rpc GetMetricValue (BasicHandleRequest)
returns (t2iapi.metric.MetricValueResponse);

/*
Change the status of an operation mode.

Expand Down