Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block elements not editable in 1.0 beta.1 #161

Closed
cpytel opened this issue Dec 3, 2018 · 6 comments · Fixed by #196
Closed

Block elements not editable in 1.0 beta.1 #161

cpytel opened this issue Dec 3, 2018 · 6 comments · Fixed by #196
Labels
released

Comments

@cpytel
Copy link

cpytel commented Dec 3, 2018

Hello, using Formeo 1.0 beta.1, I am not able to edit block elements (paragraph and header).

When trying to debug, if I manually set contenteditable=true on the element using inspector then I'm able to edit it, and when I save the form and reload the form, whatever I changed it to is in a value attribute on the element, but not in the content of the block element.
@kevinchappell
Copy link
Collaborator

@cpytel Thanks, this is a known bug. Will be resolved in the next release. 👍

@AlexBreskin
Copy link

This is still not working in the newest release at v1.03 from what I can see (hosted on https://draggable.github.io/formeo/ ), and adding contenteditable as an attribute does not seem to retain the header or paragraph information when saving the form. Is there any way to do this?

@kevinchappell
Copy link
Collaborator

Yikes, I missed this in the last release. Adding it to the top of my list and will have a fix released this weekend.

@AlexBreskin
Copy link

Yikes, I missed this in the last release. Adding it to the top of my list and will have a fix released this weekend.

Any chance we can see this in current round of releases? If it's a simple fix and you can point me to the direction of what needs changing, I can try fixing it myself and making a Pull Request to help out

@kevinchappell kevinchappell mentioned this issue Apr 13, 2019
Merged
kevinchappell added a commit that referenced this issue Apr 13, 2019
@kevinchappell
fix(controls): block elements are not editable in the editor
d099763 
resolves #161
@kevinchappell
Copy link
Collaborator

@AlexBreskinRecognite yes- this is long overdue. #196 should finally address this.

kevinchappell pushed a commit that referenced this issue Apr 13, 2019
@semantic-release-bot
chore(release): 1.0.9 [skip ci]
401c864 
## [1.0.9](v1.0.8...v1.0.9) (2019-04-13)

### Bug Fixes

* **controls:** block elements are not editable in the editor ([d099763](d099763)), closes [#161](#161)
@kevinchappell
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controls): block elements are not editable in the editor
3 participants
@cpytel @kevinchappell @AlexBreskin