Add feature: override role name displayed to end user from config option #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a configuration option which will let end users arbitrarily override the role displayed to end users from the config option
overrideRoleNameDisplay
This allows to hide a moderator with a hitched role which is unsuitable to be displayed to end users. In our case, specifically a hidden moderator with a general user role. Not able to use
fallbackRoleName
, because the hidden moderator has a hitched role.I have not coded in a very long time, and never in JS before, so rusty doesn't even begin to cover it. Thoughts/rejection/comments/patches appreciated :)
I've tested this patch on our server, and it appears to work okay, but have not tested all existing functions exhaustively