Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf 20%] System.Globalization.Tests.StringSearch (16) #2320

Open
performanceautofiler bot opened this issue Oct 16, 2020 · 0 comments
Open

[Perf 20%] System.Globalization.Tests.StringSearch (16) #2320

performanceautofiler bot opened this issue Oct 16, 2020 · 0 comments
Labels
Baseline Outlier Improvement refs/heads/master Windows 10.0.18362 x86

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 16, 2020 •
edited
Loading

Run Information

Architecture x86
OS Windows 10.0.18362
Changes diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark Baseline Test Test/Base Modality Baseline Outlier Baseline ETL Comapre ETL
IndexOf_Word_NotFound 18.91 μs 14.23 μs 0.75 False Trace Trace
LastIndexOf_Word_NotFound 28.72 μs 23.47 μs 0.82 True Trace Trace
IndexOf_Word_NotFound 18.65 μs 13.87 μs 0.74 True Trace Trace
LastIndexOf_Word_NotFound 26.71 μs 21.68 μs 0.81 False Trace Trace
LastIndexOf_Word_NotFound 25.65 μs 20.55 μs 0.80 True Trace Trace
IndexOf_Word_NotFound 18.88 μs 14.41 μs 0.76 True Trace Trace
IsSuffix_SecondHalf 28.68 μs 23.16 μs 0.81 False Trace Trace

Related Issue on x64 ubuntu

[Perf 19%] System.Globalization.Tests.StringSearch (8)

Related Issue on x64 ubuntu

[Perf 21%] System.Globalization.Tests.StringSearch (7)

Related Issue on x64 ubuntu

[Perf 21%] System.Globalization.Tests.StringSearch (9)

Related Issue on x64 Windows

[Perf 23%] System.Globalization.Tests.StringSearch (16)

graph
graph
graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Globalization.Tests.StringSearch*'

Histogram

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreCase, True))

[13583.044 ; 14824.482) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[14824.482 ; 16065.920) | 
[16065.920 ; 17307.358) | 
[17307.358 ; 18781.654) | 
[18781.654 ; 20023.092) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[20023.092 ; 21027.823) | @

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (pl-PL, None, False))

[23067.343 ; 24394.377) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[24394.377 ; 25721.410) | 
[25721.410 ; 27048.443) | 
[27048.443 ; 28160.253) | 
[28160.253 ; 29487.286) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[29487.286 ; 30691.625) | @

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreSymbols, False))

[13384.749 ; 14641.438) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[14641.438 ; 15898.126) | 
[15898.126 ; 17154.814) | 
[17154.814 ; 18471.744) | 
[18471.744 ; 19728.432) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, IgnoreCase, True))

[21225.125 ; 22555.142) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[22555.142 ; 23885.159) | 
[23885.159 ; 25215.176) | 
[25215.176 ; 26512.555) | 
[26512.555 ; 27842.572) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, IgnoreSymbols, False))

[19909.240 ; 21272.192) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[21272.192 ; 22635.144) | 
[22635.144 ; 23998.096) | 
[23998.096 ; 25437.783) | 
[25437.783 ; 26800.736) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (, None, True))

[13823.454 ; 15000.629) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[15000.629 ; 16177.804) | 
[16177.804 ; 17354.978) | 
[17354.978 ; 18699.644) | 
[18699.644 ; 19876.818) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[19876.818 ; 20624.995) | @

System.Globalization.Tests.StringSearch.IsSuffix_SecondHalf(Options: (en-US, IgnoreSymbols, False))

[22538.682 ; 23991.994) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[23991.994 ; 25445.307) | 
[25445.307 ; 26898.619) | 
[26898.619 ; 28390.047) | 
[28390.047 ; 29843.359) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[29843.359 ; 31169.243) | @@

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
This was referenced Oct 19, 2020
Closed
Open
Open
Closed
Open
Open
@performanceautofiler performanceautofiler bot mentioned this issue Oct 27, 2020
Closed
@performanceautofiler performanceautofiler bot mentioned this issue Nov 23, 2020
Closed
This was referenced Dec 8, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
This was referenced Jan 5, 2021
Closed
Open
DrewScoggins pushed a commit that referenced this issue Mar 31, 2022
@radical
Fixes for wasm builds (#2320)
7d5a03b 
* Add `--dotnet-path` to the ci scripts

For wasm builds, we use a custom dotnet populated with the bits from a
`runtime` build. And this is passed to bdn via `--cli` argument.

The project is built by `benchmarks_ci.py` first, and then run, which
then runs builds the project again via BDN, using the dotnet from the
`--cli` argument.

But this means that the project gets built with the "default" dotnet
first, and then the custom one next, which can result in a corrupted
build.

* [wasm] Validate the WasmMainJSPath early

* [wasm] Adjust some properties to improve the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Baseline Outlier Improvement refs/heads/master Windows 10.0.18362 x86
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants