Various fixes #101
Merged
Various fixes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll start testing on my end with the basic terminal commands in the readme as well |
|
ok the headless is running into issues |
|
the gui is working perfectly tho! :D |
drew@wmughal-CN4D09397T ebook2audiobook % ./ebook2audiobook.sh --headless --ebook test.txt
Running in native mode
Package requirements ok
Dictionary ok
convert_ebook() Exception: 'Namespace' object does not support item assignment
Conversion failed: 'Namespace' object does not support item assignment
drew@wmughal-CN4D09397T ebook2audiobook % |
I think I got a fix for that issue working check it out idk lol |
|
I also fixed the issue with the unwanted Windows-style line endings (\r) in the by using dos2unix on ebook2audiobook.sh to fix it :) |
|
Those two pull requests I made seem to fix everything on my end idk check em out :) |
|
yeah I fixed these since many PR |
|
unless the CRLF caused by multiple crashes on my editor. I switch it back and created a New PR with other fixes |
did you finish to modify the README? |
landonepps
reviewed
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.