Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed split_long_sentence to get_sentences, added punctuation for each language into language_mapping, unused code removed #50

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ROBERT-MCDOWELL
Copy link
Collaborator

@ROBERT-MCDOWELL ROBERT-MCDOWELL commented Nov 18, 2024

Please test it with a long chapter and long sentences in 3 different language signs (english,arabic,chinese for ex)
as I cannot do anything with my 16 years old laptop core duo with a 512MB nvidia GPU :-|

@DrewThomasson
Copy link
Owner

DrewThomasson commented Nov 19, 2024

I'll be Testing this later with my

alice_in_wonderland.txt

Along with other translations I make of it for the other languages with chatgpt lol

@DrewThomasson DrewThomasson merged commit 23a8baa into DrewThomasson:v2.0 Nov 19, 2024
@ROBERT-MCDOWELL
Copy link
Collaborator Author

I'm working to add all languages in language_mapping... tedious work...

@DrewThomasson
Copy link
Owner

DrewThomasson commented Nov 19, 2024

:o

Anything I could do to help( Whenever I have some time to spare every now and then?)

  • Sadly I might not have much time to put into the repo, as finals are coming up lol :(

Oh yeah finding voices for other languages, lol you did ask about that before ☝️ 😅

  • I can ask all my multilingual classmates for voice actor suggestions :0

@ROBERT-MCDOWELL
Copy link
Collaborator Author

It's ok I almost finished. 20 by 20 after a chagpt limitations with the right request without hallucinations...
maybe the best would be to test various new languages? does it need to update the code?

@ROBERT-MCDOWELL
Copy link
Collaborator Author

for the voices I have already some.. we will share the job but not a priority for now.. the v2 merge is...

@DrewThomasson
Copy link
Owner

Your code works in a space too btw! :D

https://huggingface.co/spaces/drewThomasson/ebook2audiobook_v2.0

@ROBERT-MCDOWELL
Copy link
Collaborator Author

Hurrayy! :D... the get_sentences + enable_text_splitting=True is not to bad, but sometimes word repetition and not enough space between some end of sentence and start of the following....

@DrewThomasson
Copy link
Owner

DrewThomasson commented Nov 19, 2024

hm, Well I think the word repetition was already a thing.

That's just a thing that happens with xtts for some reason.

I don't think it happens for fairseq at least lol

@ROBERT-MCDOWELL
Copy link
Collaborator Author

this will be the last thing to solve before the merge... GN!

@DrewThomasson
Copy link
Owner

kk GN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants