Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Bintray and JCenter for the dependencies #338

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Optimize Bintray and JCenter for the dependencies #338

merged 4 commits into from
Mar 18, 2021

Conversation

ykws
Copy link
Contributor

@ykws ykws commented Mar 9, 2021 •
edited
Loading

Issue

Overview (Required)

  • Not completed to remove JCenter
  • Remove Bintray
  • JCenter only for the dependencies described within the block

Links

Screenshot

Screen not changed.

@ykws ykws changed the title Remove Bintray and JCenter [WIP] Remove Bintray and JCenter Mar 10, 2021
@anandwana001
Copy link
Contributor

@ykws Is it building successfully on the local machine?

reference article - https://jeroenmols.com/blog/2021/02/04/migratingjcenter/

@ykws ykws marked this pull request as draft March 10, 2021 09:36
@ykws
Copy link
Contributor Author

ykws commented Mar 10, 2021

@anandwana001 Yes, However, it may have been successful with the gradle cache.
Thank you for the reference article. I will check it.

@ykws ykws changed the title [WIP] Remove Bintray and JCenter [WIP] Optimize Bintray and JCenter for the dependencies Mar 17, 2021
@github-actions github-actions bot temporarily deployed to deploygate-distribution March 17, 2021 18:21 Inactive
@ykws ykws changed the title [WIP] Optimize Bintray and JCenter for the dependencies Optimize Bintray and JCenter for the dependencies Mar 17, 2021
@ykws ykws marked this pull request as ready for review March 17, 2021 18:21
@ykws
Copy link
Contributor Author

ykws commented Mar 17, 2021

I'm sorry. I have abandoned the perfect fixes for this issue.
Ready for review this pull request as a better practice that now I think.

@punchdrunker
Copy link
Member

👀

@punchdrunker punchdrunker self-requested a review March 18, 2021 01:13
punchdrunker
punchdrunker reviewed Mar 18, 2021
View reviewed changes
build.gradle
@@ -8,8 +8,15 @@ buildscript {
repositories {
google()
mavenCentral()
jcenter()
maven { url = "https://dl.bintray.com/kotlin/kotlin-eap" }
// This snippet enables jcenter only for the dependencies described within the block.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the helpful comment

punchdrunker
punchdrunker approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@punchdrunker punchdrunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@punchdrunker punchdrunker merged commit 1569504 into DroidKaigi:main Mar 18, 2021
This was referenced Mar 18, 2021
Closed
Open
Open
@ykws ykws deleted the feature/remove-jcenter branch March 18, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punchdrunker punchdrunker punchdrunker approved these changes

Assignees
No one assigned
Labels
awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usages of jcenter()
4 participants
@ykws @anandwana001 @punchdrunker @takahirom