Fix language settings #726
Conversation
| } | ||
| val configuration = resources.configuration | ||
| configuration.setLocale(locale) | ||
| resources.updateConfiguration(configuration, resources.displayMetrics) |
There was a problem hiding this comment.
updateConfiguration() is deprecated but it can simplify implementation.
If there is a better way to implement this, it may be better to change it...
There was a problem hiding this comment.
Thanks for addressing this issue 👍
How about adding the following code to uicomponent-compose:core ?
This way, you don't need to rely on updateConfiguration.
private val TextSettingLocal = compositionLocalOf<>()
@Coposable
fun MultiLangText.getTextWithSetting() {
when(LocalLangSetting.current) {
Lang.SYSTEM -> currentLangTitle
...
}
}There was a problem hiding this comment.
Thanks your proposal !
I implemented it as a trial. 28e48c7
If it looks like ok, I'll try to rewrite the other places.
|
👀 |
| } | ||
|
|
||
| @JvmInline | ||
| value class LangSettingProvidableCompositionLocal internal constructor( |
There was a problem hiding this comment.
I'm still not sure if this value class approach is good or bad. Is there any reason for this? 👀
There was a problem hiding this comment.
Sorry, I'm also not sure all that well.
I use this approach that is used in Coil.
It seems like a good approach that current can implement custom getter (can use composable function).
If coil, it is needed the context to get the ImageLoader so can use LocalContext, but this does not require composable functions so it might not make sense...
https://github.com/coil-kt/coil/blob/99c45789ec19895f657d0be7303da2e666b64f14/coil-compose-singleton/src/main/java/coil/compose/LocalImageLoader.kt#L51
because 0.39.0 is not supported 'value class'
myoshita
force-pushed
the
fix/language-settings
branch
from
28e48c7 to
a29f7fa
Compare
| @Composable | ||
| fun Lang?.getTitle(): String { |
There was a problem hiding this comment.
Delete context and add composable annotation.
This maybe resolves #694
| @@ -67,7 +67,7 @@ allprojects { | |||
| targetExclude('bin/**/*.kt') | |||
| targetExclude("**/generated/**/*.kt") | |||
|
|
|||
| ktlint("0.39.0") | |||
| ktlint("0.42.1") | |||
There was a problem hiding this comment.
Upgrade ktlint because value class is not supported.
|
Thank you for the cool pull request 🆒 |
Issue
Overview (Required)
combine().Links
Screenshot