Close open files on error within SW_netCDF.c
#429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SOILWAT2 v8.0.0, there is a bug where the two functions -
SW_NC_write_output()
&SW_NC_read_out_vars()
- upon error, the open file does not get closedThe mentioned two functions now close files upon failure before leaving the function
See SW_NC_read_out_vars() doesn't close file connection #424 and SW_NC_write_output() doesn't close open files on error #426