Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close open files on error within SW_netCDF.c #429

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

N1ckP3rsl3y
Copy link
Contributor

- `SW_NC_write_output()` & `SW_NC_read_out_vars()`
	* New goto target to close open file
	* Use goto instead of return upon failure

- Issues #424 and #426
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.33%. Comparing base (1605a74) to head (f657982).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/devel_v8.1.0     #429   +/-   ##
=====================================================
  Coverage                 73.33%   73.33%           
=====================================================
  Files                        20       20           
  Lines                      6233     6233           
=====================================================
  Hits                       4571     4571           
  Misses                     1662     1662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dschlaep dschlaep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! All changes to file "SW_Control.c", however, are temporary debugging code that should not be here, please remove.

@N1ckP3rsl3y N1ckP3rsl3y merged commit 54abffe into release/devel_v8.1.0 Aug 8, 2024
12 checks passed
@N1ckP3rsl3y N1ckP3rsl3y deleted the fix_closeOpenFilesOnFailNC branch August 8, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SW_NC_write_output() doesn't close open files on error SW_NC_read_out_vars() doesn't close file connection
2 participants