This repository was archived by the owner on Feb 23, 2025. It is now read-only.
Add ErrorDescription to result of RefreshTokenAsync error
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response.ErrorDescriptioncontains additional info to theresponse.Error. This is very valuable especially sinceinvalid_granterror is a bucket for a number of errors. For example "invalid refresh token", "refresh token expired", "server clock out of sync".Refer to this post for more examples of what an
invalid_granterror could be.This change was tested locally and does indeed allow us (as a consumer of this OIDC library) to get access to the ErrorDescription, which in our case is an "Invalid refresh token" error. Without this fix we only get
invalid_grantwith no additional information.