This repository was archived by the owner on Feb 23, 2025. It is now read-only.
Test & Fix for issue #266: Refresh tokens with sliding refresh tokens #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andler as a singleton)
…hen using refresh tokens with sliding expirations)
|
Hmmm. A case of "works on my machine", even though it was tried with much higher concurrency and iteration count... At least the test does demonstrate the race condition. |
|
Reproduced "on the local machine" too :-) |
|
thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can reproduce the race condition using the tests in commit 599f810.
The last commit (21c8f1c) fixes the race condition.
The race condition only occurs when using refresh tokens with sliding expiration.
Because for these refresh tokens, the refresh token gets immediately invalidated when another thread uses the refresh token to get a new access token.